[Webkit-unassigned] [Bug 159552] [GStreamer][GL] crash within triggerRepaint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 23:46:59 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159552

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #7)
> Comment on attachment 283139 [details]
> patch
> 
> > I understand the concerns about reducing performance but if there isn't we
> > should create a function to do something like:
> > 
> > {
> >      auto weakThis = player.createWeakPtr();
> >      RunLoop::main().runNowIfMainThreadOrdispatch([weakThis]) { 
> >          if (weakThis)
> >              weakThis->m_player->sizeChanged();
> >      });
> > }
> > 
> > Otherwise I think we are creating these code structures and IMHO it makes
> > code hard to read.
> 
> Let's not block landing this because of this nit, but please, open a new bug
> about this.

A nit? This is needed to avoid a crash because of a user after free, I wouldn't say it's a nit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160713/b20a364d/attachment.html>


More information about the webkit-unassigned mailing list