[Webkit-unassigned] [Bug 159466] [GStreamer][GL] switch to appsink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159466

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 282884 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282884&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:133
> >> +
> > 
> > This shouldn't be public, make the callbacks private static members if you need to access private API instead of exposing it.
> 
> Why?

Because it's only used internally, you made it public to call it from static functions, not to make it really public API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160706/d4aa4fa0/attachment.html>