[Webkit-unassigned] [Bug 159466] [GStreamer][GL] switch to appsink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159466

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 282889
  --> https://bugs.webkit.org/attachment.cgi?id=282889
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282889&action=review

I leave Carlos the r+ as he reviwed first.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:176
> +            g_signal_handlers_disconnect_matched(appsink.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);

Nit that I recommend to change before landing: g_signal_handlers_disconnect_by_data is less complex to use and more readable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160706/95b63c13/attachment-0001.html>