<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][GL] switch to appsink"
href="https://bugs.webkit.org/show_bug.cgi?id=159466#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][GL] switch to appsink"
href="https://bugs.webkit.org/show_bug.cgi?id=159466">bug 159466</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159466#c3">comment #3</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=282884&action=diff" name="attach_282884" title="patch">attachment 282884</a> <a href="attachment.cgi?id=282884&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282884&action=review">https://bugs.webkit.org/attachment.cgi?id=282884&action=review</a>
>
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:133
> >> +
> >
> > This shouldn't be public, make the callbacks private static members if you need to access private API instead of exposing it.
>
> Why?</span >
Because it's only used internally, you made it public to call it from static functions, not to make it really public API.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>