<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][GL] switch to appsink"
href="https://bugs.webkit.org/show_bug.cgi?id=159466#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][GL] switch to appsink"
href="https://bugs.webkit.org/show_bug.cgi?id=159466">bug 159466</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier RodrÃguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier RodrÃguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282889&action=diff" name="attach_282889" title="patch">attachment 282889</a> <a href="attachment.cgi?id=282889&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282889&action=review">https://bugs.webkit.org/attachment.cgi?id=282889&action=review</a>
I leave Carlos the r+ as he reviwed first.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:176
> + g_signal_handlers_disconnect_matched(appsink.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);</span >
Nit that I recommend to change before landing: g_signal_handlers_disconnect_by_data is less complex to use and more readable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>