[Webkit-unassigned] [Bug 153516] Web Inspector: High Level Memory Overview Instrument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153516

--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 269943
  --> https://bugs.webkit.org/attachment.cgi?id=269943
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=269943&action=review

>> LayoutTests/inspector/memory/tracking.html:26
>> +                let types = categories.reduce((list, x) => { list.push(x.type); return list; }, []).sort();
> 
> This should be Array.prototype.map.

I suppose I could, but I didn't want to modify the list the incoming list. Side-effects make it hard to debug in the future.

>> Source/JavaScriptCore/inspector/protocol/Memory.json:8
>> +            "id": "Event",
> 
> I can't figure out this name. Why? I would have said 'ResourceUsageData' or something.

That was just going to be my trend:

    ScriptProfiler.startTracking => ScriptProfiler.Event in trackingUpdate
    Memory.startTracking => Memory.Event in trackingUpdate
    Heap.startTracking => Heap.Event in trackingUpdate

>> Source/JavaScriptCore/inspector/protocol/Memory.json:39
>> +                { "name": "timestamp", "type": "number" }
> 
> One parameter per line, please. That is how most inspector protocol specifications are formatted.

?

>> Source/JavaScriptCore/inspector/scripts/codegen/generator.py:41
>> +_ALWAYS_UPPERCASED_ENUM_VALUE_SUBSTRINGS = set(['API', 'CSS', 'DOM', 'HTML', 'JIT', 'XHR', 'XML'])
> 
> Did you rebaseline the generator tests?

I didn't but this string would not have existed.

>> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:66
>> +        // FIXME: UI To pick and choose Instruments.
> 
> What?

The new Timelines UI will allow adding / removing / changing instruments. I'll just remove these lines in my next iteration of the patch, but this is where you have to manually add the instrument to test it until the new picker/configuration UI becomes available.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/80864095/attachment-0001.html>