[Webkit-unassigned] [Bug 153516] Web Inspector: High Level Memory Overview Instrument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153516

--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 269943
  --> https://bugs.webkit.org/attachment.cgi?id=269943
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=269943&action=review

> Source/WebInspectorUI/ChangeLog:8
> +

Needs summary.

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:66
> +        // FIXME: UI To pick and choose Instruments.

What?

> Source/WebInspectorUI/UserInterface/Models/MemoryCategory.js:26
> +WebInspector.MemoryCategory = class MemoryCategory extends WebInspector.Object

Again, this is an off-putting name for the thing that holds pieces of data and can have lots of instances. At the least, add a -Data suffix to make it clearer.

> Source/WebInspectorUI/UserInterface/Models/MemoryTimelineRecord.js:86
> +    get totalSize() { return this._totalSize; }

Please add a line here for // TimelineRecord API

> Source/WebInspectorUI/UserInterface/Protocol/MemoryObserver.js:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

oops

> Source/WebInspectorUI/UserInterface/Views/CircleChart.css:31
> +    fill: rgba(0, 0, 0, 0.02);

hsla()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/9c068419/attachment.html>