<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: High Level Memory Overview Instrument"
href="https://bugs.webkit.org/show_bug.cgi?id=153516#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: High Level Memory Overview Instrument"
href="https://bugs.webkit.org/show_bug.cgi?id=153516">bug 153516</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269943&action=diff" name="attach_269943" title="[PATCH] Proposed Fix">attachment 269943</a> <a href="attachment.cgi?id=269943&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269943&action=review">https://bugs.webkit.org/attachment.cgi?id=269943&action=review</a>
<span class="quote">>> LayoutTests/inspector/memory/tracking.html:26
>> + let types = categories.reduce((list, x) => { list.push(x.type); return list; }, []).sort();
>
> This should be Array.prototype.map.</span >
I suppose I could, but I didn't want to modify the list the incoming list. Side-effects make it hard to debug in the future.
<span class="quote">>> Source/JavaScriptCore/inspector/protocol/Memory.json:8
>> + "id": "Event",
>
> I can't figure out this name. Why? I would have said 'ResourceUsageData' or something.</span >
That was just going to be my trend:
ScriptProfiler.startTracking => ScriptProfiler.Event in trackingUpdate
Memory.startTracking => Memory.Event in trackingUpdate
Heap.startTracking => Heap.Event in trackingUpdate
<span class="quote">>> Source/JavaScriptCore/inspector/protocol/Memory.json:39
>> + { "name": "timestamp", "type": "number" }
>
> One parameter per line, please. That is how most inspector protocol specifications are formatted.</span >
?
<span class="quote">>> Source/JavaScriptCore/inspector/scripts/codegen/generator.py:41
>> +_ALWAYS_UPPERCASED_ENUM_VALUE_SUBSTRINGS = set(['API', 'CSS', 'DOM', 'HTML', 'JIT', 'XHR', 'XML'])
>
> Did you rebaseline the generator tests?</span >
I didn't but this string would not have existed.
<span class="quote">>> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:66
>> + // FIXME: UI To pick and choose Instruments.
>
> What?</span >
The new Timelines UI will allow adding / removing / changing instruments. I'll just remove these lines in my next iteration of the patch, but this is where you have to manually add the instrument to test it until the new picker/configuration UI becomes available.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>