<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: High Level Memory Overview Instrument"
   href="https://bugs.webkit.org/show_bug.cgi?id=153516#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: High Level Memory Overview Instrument"
   href="https://bugs.webkit.org/show_bug.cgi?id=153516">bug 153516</a>
              from <span class="vcard"><a class="email" href="mailto:bburg&#64;apple.com" title="Brian Burg &lt;bburg&#64;apple.com&gt;"> <span class="fn">Brian Burg</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=269943&amp;action=diff" name="attach_269943" title="[PATCH] Proposed Fix">attachment 269943</a> <a href="attachment.cgi?id=269943&amp;action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269943&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=269943&amp;action=review</a>

<span class="quote">&gt; Source/WebInspectorUI/ChangeLog:8
&gt; +</span >

Needs summary.

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:66
&gt; +        // FIXME: UI To pick and choose Instruments.</span >

What?

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Models/MemoryCategory.js:26
&gt; +WebInspector.MemoryCategory = class MemoryCategory extends WebInspector.Object</span >

Again, this is an off-putting name for the thing that holds pieces of data and can have lots of instances. At the least, add a -Data suffix to make it clearer.

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Models/MemoryTimelineRecord.js:86
&gt; +    get totalSize() { return this._totalSize; }</span >

Please add a line here for // TimelineRecord API

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Protocol/MemoryObserver.js:2
&gt; + * Copyright (C) 2015 Apple Inc. All rights reserved.</span >

oops

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Views/CircleChart.css:31
&gt; +    fill: rgba(0, 0, 0, 0.02);</span >

hsla()?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>