[Webkit-unassigned] [Bug 153405] [GTK] Implement overlay scrollbars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153405

--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #16)
> Comment on attachment 269994 [details]
> Rebased patch
> 
> I reviewed the "updated patch" from yesterday and just let it sit a day to
> see if anyone else would comment; I presume there aren't many changes in
> "rebased patch."

No changes, I submitted it again rebased just to make sure it passed EWS.

> You addressed most of my comments already. The one thing I would add is that
> ENABLE_SMOOTH_SCROLLING is not a public option for our port, so I would
> remove the include guards for it. If you want to allow disabling smooth
> scrolling, we should make it a public option.

In that case we should just remove the option from GTK cmake files, and enable it unconditionally in Platform.h, and then remove the ifdefs from GTK files. Not something I would do as part of this patch.

> I'm looking forward to the scroll animator tests requested by
> Simon/Darin/Beth. :)

The major blocker of this patch is bug #153404, so I'll wait a bit to land it, or I could land it disabled by default (inverting the logic of the env variable) until bug #153404 is fixed. Meanwhile I will work on the tests and some other minor issues related to scrollbars that we still have pending.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/81df0d89/attachment.html>