<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Implement overlay scrollbars"
href="https://bugs.webkit.org/show_bug.cgi?id=153405#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Implement overlay scrollbars"
href="https://bugs.webkit.org/show_bug.cgi?id=153405">bug 153405</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153405#c16">comment #16</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=269994&action=diff" name="attach_269994" title="Rebased patch">attachment 269994</a> <a href="attachment.cgi?id=269994&action=edit" title="Rebased patch">[details]</a></span>
> Rebased patch
>
> I reviewed the "updated patch" from yesterday and just let it sit a day to
> see if anyone else would comment; I presume there aren't many changes in
> "rebased patch."</span >
No changes, I submitted it again rebased just to make sure it passed EWS.
<span class="quote">> You addressed most of my comments already. The one thing I would add is that
> ENABLE_SMOOTH_SCROLLING is not a public option for our port, so I would
> remove the include guards for it. If you want to allow disabling smooth
> scrolling, we should make it a public option.</span >
In that case we should just remove the option from GTK cmake files, and enable it unconditionally in Platform.h, and then remove the ifdefs from GTK files. Not something I would do as part of this patch.
<span class="quote">> I'm looking forward to the scroll animator tests requested by
> Simon/Darin/Beth. :)</span >
The major blocker of this patch is <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r188659): Non main frame scrollable areas don't work for pages restored from the page cache"
href="show_bug.cgi?id=153404">bug #153404</a>, so I'll wait a bit to land it, or I could land it disabled by default (inverting the logic of the env variable) until <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r188659): Non main frame scrollable areas don't work for pages restored from the page cache"
href="show_bug.cgi?id=153404">bug #153404</a> is fixed. Meanwhile I will work on the tests and some other minor issues related to scrollbars that we still have pending.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>