[Webkit-unassigned] [Bug 153405] [GTK] Implement overlay scrollbars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153405

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269994|review?                     |review+
              Flags|                            |

--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 269994
  --> https://bugs.webkit.org/attachment.cgi?id=269994
Rebased patch

I reviewed the "updated patch" from yesterday and just let it sit a day to see if anyone else would comment; I presume there aren't many changes in "rebased patch."

You addressed most of my comments already. The one thing I would add is that ENABLE_SMOOTH_SCROLLING is not a public option for our port, so I would remove the include guards for it. If you want to allow disabling smooth scrolling, we should make it a public option.

I'm looking forward to the scroll animator tests requested by Simon/Darin/Beth. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160127/9519b662/attachment-0001.html>