[Webkit-unassigned] [Bug 152910] Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152910

--- Comment #15 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #14)
> Comment on attachment 268920 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268920&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:34
> > +    this.element = document.createElement("div");
> > +    this.element.classList.add("queue-view");
> > +    this.element.__queueView = this;
> > +
> > +    this.queues = queues || [];
> > +
> > +    BaseObject.call(this);
> 
> It may be nice if we could make this class extend QueueView instead of
> duplicating similar logic here. We can do that in a separate patch if it
> turns out to be useful.

I will look into this for a future patch.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:47
> > +                "WebKit Repo": 33020
> 
> Nit: You may want to consider using the same repository name as used in
> production.

I did this.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockOverrides.js:26
> > +// The real "label" setter was throwing an exception in the unit tests so I overrode it with a simplified version.
> 
> Should this be a FIXME comment?

I investigated this further. The error that I was working around seemed to be particular to PhantomJS but did not affect regular usage (i.e. running the tests in Safari). Therefore I just removed this file from that patch.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:29
> > +    <meta charset="UTF-8" />
> 
> Nit: The slash is not necessary as this is a HTML5 document.

Removed the slash.

Landed https://trac.webkit.org/changeset/195062

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160114/71aabfbc/attachment.html>