[Webkit-unassigned] [Bug 152910] Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 13 17:58:43 PST 2016


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #268920|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #14 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 268920
  --> https://bugs.webkit.org/attachment.cgi?id=268920

View in context: https://bugs.webkit.org/attachment.cgi?id=268920&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:34
> +    this.element = document.createElement("div");
> +    this.element.classList.add("queue-view");
> +    this.element.__queueView = this;
> +
> +    this.queues = queues || [];
> +
> +    BaseObject.call(this);

It may be nice if we could make this class extend QueueView instead of duplicating similar logic here. We can do that in a separate patch if it turns out to be useful.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:47
> +                "WebKit Repo": 33020

Nit: You may want to consider using the same repository name as used in production.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockOverrides.js:26
> +// The real "label" setter was throwing an exception in the unit tests so I overrode it with a simplified version.

Should this be a FIXME comment?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:29
> +    <meta charset="UTF-8" />

Nit: The slash is not necessary as this is a HTML5 document.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160114/78733ab2/attachment.html>

More information about the webkit-unassigned mailing list