<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910">bug 152910</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152910#c14">comment #14</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=268920&action=diff" name="attach_268920" title="Patch">attachment 268920</a> <a href="attachment.cgi?id=268920&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=268920&action=review">https://bugs.webkit.org/attachment.cgi?id=268920&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:34
> > + this.element = document.createElement("div");
> > + this.element.classList.add("queue-view");
> > + this.element.__queueView = this;
> > +
> > + this.queues = queues || [];
> > +
> > + BaseObject.call(this);
>
> It may be nice if we could make this class extend QueueView instead of
> duplicating similar logic here. We can do that in a separate patch if it
> turns out to be useful.</span >
I will look into this for a future patch.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:47
> > + "WebKit Repo": 33020
>
> Nit: You may want to consider using the same repository name as used in
> production.</span >
I did this.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockOverrides.js:26
> > +// The real "label" setter was throwing an exception in the unit tests so I overrode it with a simplified version.
>
> Should this be a FIXME comment?</span >
I investigated this further. The error that I was working around seemed to be particular to PhantomJS but did not affect regular usage (i.e. running the tests in Safari). Therefore I just removed this file from that patch.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:29
> > + <meta charset="UTF-8" />
>
> Nit: The slash is not necessary as this is a HTML5 document.</span >
Removed the slash.
Landed <a href="https://trac.webkit.org/changeset/195062">https://trac.webkit.org/changeset/195062</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>