<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910">bug 152910</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268920 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910">bug 152910</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268920&action=diff" name="attach_268920" title="Patch">attachment 268920</a> <a href="attachment.cgi?id=268920&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268920&action=review">https://bugs.webkit.org/attachment.cgi?id=268920&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:34
> + this.element = document.createElement("div");
> + this.element.classList.add("queue-view");
> + this.element.__queueView = this;
> +
> + this.queues = queues || [];
> +
> + BaseObject.call(this);</span >
It may be nice if we could make this class extend QueueView instead of duplicating similar logic here. We can do that in a separate patch if it turns out to be useful.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:47
> + "WebKit Repo": 33020</span >
Nit: You may want to consider using the same repository name as used in production.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockOverrides.js:26
> +// The real "label" setter was throwing an exception in the unit tests so I overrode it with a simplified version.</span >
Should this be a FIXME comment?
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:29
> + <meta charset="UTF-8" /></span >
Nit: The slash is not necessary as this is a HTML5 document.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>