[Webkit-unassigned] [Bug 125005] [GTK] HTML5 required attribute validation messages implemented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 19:51:10 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #218165|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 218165
  --> https://bugs.webkit.org/attachment.cgi?id=218165
Proposed patch

Sorry for the late review. Thanks for working on this. This patch looks good, except new translatable strings really need to have translator comments. Please leave a comment on the line above each new string, to help translators figure out what the string is for. For example:

// Translators: Displayed when required form field is left empty.
return String::fromUTF8(_("Please fill out this field."));

We ought to add comments for the other strings in this file as well, but for now let's just worry about not introducing new strings that lack comments.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160107/8030a13a/attachment.html>

More information about the webkit-unassigned mailing list