<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] HTML5 required attribute validation messages implemented"
href="https://bugs.webkit.org/show_bug.cgi?id=125005">bug 125005</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #218165 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] HTML5 required attribute validation messages implemented"
href="https://bugs.webkit.org/show_bug.cgi?id=125005#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] HTML5 required attribute validation messages implemented"
href="https://bugs.webkit.org/show_bug.cgi?id=125005">bug 125005</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=218165&action=diff" name="attach_218165" title="Proposed patch">attachment 218165</a> <a href="attachment.cgi?id=218165&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
Sorry for the late review. Thanks for working on this. This patch looks good, except new translatable strings really need to have translator comments. Please leave a comment on the line above each new string, to help translators figure out what the string is for. For example:
// Translators: Displayed when required form field is left empty.
return String::fromUTF8(_("Please fill out this field."));
We ought to add comments for the other strings in this file as well, but for now let's just worry about not introducing new strings that lack comments.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>