[Webkit-unassigned] [Bug 137974] [GTK] Prefer GTK implementation over native Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137974

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240284|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 240284
  --> https://bugs.webkit.org/attachment.cgi?id=240284
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240284&action=review

Milan, sorry for the late review. I'm going to r- this simply because the GTK port does not have any support for Windows anymore. If that situation ever changes (if you or someone else ever gets it working), then of course it would make sense to reconsider this patch.

> Source/WTF/wtf/Compiler.h:97
> +#define WTF_COMPILER_GCC 1

I don't think this is right; a quick Google search tells me that MinGW supports Clang. Even though clang pretends to be GCC, we don't want COMPILER(GCC) to return true unless the compiler really is GCC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160107/291341eb/attachment.html>