[Webkit-unassigned] [Bug 150927] Inconsistencies in main resource load delegates when loading from history

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 11:20:28 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=150927

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264862|review?                     |review+
              Flags|                            |

--- Comment #28 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 264862
  --> https://bugs.webkit.org/attachment.cgi?id=264862
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264862&action=review

No further objections -> r=me

As a bonus, I think this might fix bug #59111; someone with a Mac ought to check.

> LayoutTests/http/tests/loading/main-resource-delegates-on-back-navigation.html:7
> +//window.jsTestIsAsync = true;

Don't forget to fix these stale comments.

>> Source/WebCore/loader/FrameLoader.cpp:1872
>> +        // Main resource delegates were already sent, se we skip the first response here.
> 
> (typo: se -> so)

Reminder: se -> so

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/dcbb8f06/attachment.html>


More information about the webkit-unassigned mailing list