[Webkit-unassigned] [Bug 132671] [GStreamer] A video element isn't drawn onto the canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132671

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249927|review?                     |review+
              Flags|                            |

--- Comment #30 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 249927
  --> https://bugs.webkit.org/attachment.cgi?id=249927
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249927&action=review

I only spot-checked this for obvious C++ errors, since not familiar with this code, but most of these changes only execute when two experimental build options are enabled (ACCELERATED_2D_CANVAS and USE_GSTREAMER_GL), neither of which we are likely to turn on for end users anytime soon, so it seems silly for this to be stalled on request queue any longer.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:275
> +            // The destination rectangle will have it's width and height already reversed for the orientation of

it's -> its

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/0537076a/attachment.html>