<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Inconsistencies in main resource load delegates when loading from history"
href="https://bugs.webkit.org/show_bug.cgi?id=150927">bug 150927</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #264862 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Inconsistencies in main resource load delegates when loading from history"
href="https://bugs.webkit.org/show_bug.cgi?id=150927#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Inconsistencies in main resource load delegates when loading from history"
href="https://bugs.webkit.org/show_bug.cgi?id=150927">bug 150927</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264862&action=diff" name="attach_264862" title="Updated patch">attachment 264862</a> <a href="attachment.cgi?id=264862&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264862&action=review">https://bugs.webkit.org/attachment.cgi?id=264862&action=review</a>
No further objections -> r=me
As a bonus, I think this might fix <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2: Secure text input is not enabled when going back to a cached page"
href="show_bug.cgi?id=59111">bug #59111</a>; someone with a Mac ought to check.
<span class="quote">> LayoutTests/http/tests/loading/main-resource-delegates-on-back-navigation.html:7
> +//window.jsTestIsAsync = true;</span >
Don't forget to fix these stale comments.
<span class="quote">>> Source/WebCore/loader/FrameLoader.cpp:1872
>> + // Main resource delegates were already sent, se we skip the first response here.
>
> (typo: se -> so)</span >
Reminder: se -> so</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>