[Webkit-unassigned] [Bug 154484] Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154484

--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 271958
  --> https://bugs.webkit.org/attachment.cgi?id=271958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271958&action=review

>>> Source/WebCore/platform/text/LocaleICU.h:86
>>> +#endif
>> 
>> Would be better to initialize these data members here. Then we would not need the conditional initialization lines in the constructor.
> 
> But the UNumberFormat type would be unknown, and we would have to forward-declare it to allow using a pointer on it.
> 
> Is it worth doing this?
> If so, I can resend a patch.

We can initialize to null without any other changes:

#if !UCONFIG_NO_FORMATTING
    UNumberFormat* m_numberFormat { nullptr };
    bool m_didCreateDecimalFormat { false };
#endif

I don’t know what you mean by “we would have to forward-declare it”.

And yes, I do think it’s worth doing this so we can remove the four lines of code in the constructor that conditionally initialize these data members.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160224/b46bd5b3/attachment.html>