[Webkit-unassigned] [Bug 154484] Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154484

--- Comment #9 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #6)
> Comment on attachment 271958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271958&action=review
> 
> > Source/WebCore/platform/text/LocaleICU.h:86
> > +#if !UCONFIG_NO_FORMATTING
> >      UNumberFormat* m_numberFormat;
> >      bool m_didCreateDecimalFormat;
> > +#endif
> 
> Would be better to initialize these data members here. Then we would not
> need the conditional initialization lines in the constructor.

But the UNumberFormat type would be unknown, and we would have to forward-declare it to allow using a pointer on it.

Is it worth doing this?
If so, I can resend a patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160224/dc337d9d/attachment-0001.html>