<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484">bug 154484</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271958&action=diff" name="attach_271958" title="Patch">attachment 271958</a> <a href="attachment.cgi?id=271958&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271958&action=review">https://bugs.webkit.org/attachment.cgi?id=271958&action=review</a>
<span class="quote">>>> Source/WebCore/platform/text/LocaleICU.h:86
>>> +#endif
>>
>> Would be better to initialize these data members here. Then we would not need the conditional initialization lines in the constructor.
>
> But the UNumberFormat type would be unknown, and we would have to forward-declare it to allow using a pointer on it.
>
> Is it worth doing this?
> If so, I can resend a patch.</span >
We can initialize to null without any other changes:
#if !UCONFIG_NO_FORMATTING
UNumberFormat* m_numberFormat { nullptr };
bool m_didCreateDecimalFormat { false };
#endif
I don’t know what you mean by “we would have to forward-declare it”.
And yes, I do think it’s worth doing this so we can remove the four lines of code in the constructor that conditionally initialize these data members.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>