[Webkit-unassigned] [Bug 154450] [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 10:38:43 PST 2016


--- Comment #11 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 271864
  --> https://bugs.webkit.org/attachment.cgi?id=271864

View in context: https://bugs.webkit.org/attachment.cgi?id=271864&action=review

>> Source/WebKit2/CMakeLists.txt:-789
>> -    set_target_properties(WebKit2 PROPERTIES OUTPUT_NAME ${WebKit2_OUTPUT_NAME})
> I was under the impression set_target_properties only worked after the target had been made with add_library already.  This is only used on Windows to my knowledge, and Windows EWS would report a successful build with different output names, which we would not want.

GTK+ port uses WebKit2_OUTPUT_NAME, and I've verified that it works.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/f679e50b/attachment.html>

More information about the webkit-unassigned mailing list