[Webkit-unassigned] [Bug 154450] [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154450

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271864|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 271864
  --> https://bugs.webkit.org/attachment.cgi?id=271864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271864&action=review

>>> Source/WebKit2/CMakeLists.txt:-789
>>> -    set_target_properties(WebKit2 PROPERTIES OUTPUT_NAME ${WebKit2_OUTPUT_NAME})
>> 
>> I was under the impression set_target_properties only worked after the target had been made with add_library already.  This is only used on Windows to my knowledge, and Windows EWS would report a successful build with different output names, which we would not want.
> 
> GTK+ port uses WebKit2_OUTPUT_NAME, and I've verified that it works.

ok, sounds good.  I'll take a close look at the output after this lands, but I don't anticipate any problems, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/c7632bcf/attachment-0001.html>