<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro."
href="https://bugs.webkit.org/show_bug.cgi?id=154450#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro."
href="https://bugs.webkit.org/show_bug.cgi?id=154450">bug 154450</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271864&action=diff" name="attach_271864" title="Patch">attachment 271864</a> <a href="attachment.cgi?id=271864&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271864&action=review">https://bugs.webkit.org/attachment.cgi?id=271864&action=review</a>
<span class="quote">>> Source/WebKit2/CMakeLists.txt:-789
>> - set_target_properties(WebKit2 PROPERTIES OUTPUT_NAME ${WebKit2_OUTPUT_NAME})
>
> I was under the impression set_target_properties only worked after the target had been made with add_library already. This is only used on Windows to my knowledge, and Windows EWS would report a successful build with different output names, which we would not want.</span >
GTK+ port uses WebKit2_OUTPUT_NAME, and I've verified that it works.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>