[Webkit-unassigned] [Bug 154235] [GTK][GStreamer] ClearKey EME v1 decryption support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154235

--- Comment #16 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #14)
> (In reply to comment #11)
> > (In reply to comment #9)
> > > (In reply to comment #8)
> > > > (In reply to comment #7)
> > > > > 
> > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:896
> > > > > > +    if (!equalIgnoringASCIICase(keySystem, "org.w3.clearkey"))
> > > > > > +        return MediaPlayer::KeySystemNotSupported;
> > > > > 
> > > > > Instead of duplication this check here, we could call supportsKeySystem
> > > > > instead, or move this check to a helper function and use it from both places.
> > > > > 
> > > > 
> > > > I'm not sure it's worth.
> > > 
> > > If the condition changes for whatever reason you will have to change it
> > > everywhere.
> > > 
> > 
> > In two places. I know we are lazy developers, but this is not worth the
> > refactoring effort at this point, imho :)
> 
> You don't need any refactoring, just call the existing function that already
> checks this.

So you suggest to call supportsKeySystem() right? but addKey() and generateKeyRequest() have no mimeType param

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/fe9301a7/attachment.html>