<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235">bug 154235</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154235#c14">comment #14</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=154235#c11">comment #11</a>)
> > (In reply to <a href="show_bug.cgi?id=154235#c9">comment #9</a>)
> > > (In reply to <a href="show_bug.cgi?id=154235#c8">comment #8</a>)
> > > > (In reply to <a href="show_bug.cgi?id=154235#c7">comment #7</a>)
> > > > >
> > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:896
> > > > > > + if (!equalIgnoringASCIICase(keySystem, "org.w3.clearkey"))
> > > > > > + return MediaPlayer::KeySystemNotSupported;
> > > > >
> > > > > Instead of duplication this check here, we could call supportsKeySystem
> > > > > instead, or move this check to a helper function and use it from both places.
> > > > >
> > > >
> > > > I'm not sure it's worth.
> > >
> > > If the condition changes for whatever reason you will have to change it
> > > everywhere.
> > >
> >
> > In two places. I know we are lazy developers, but this is not worth the
> > refactoring effort at this point, imho :)
>
> You don't need any refactoring, just call the existing function that already
> checks this.</span >
So you suggest to call supportsKeySystem() right? but addKey() and generateKeyRequest() have no mimeType param</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>