[Webkit-unassigned] [Bug 154235] [GTK][GStreamer] ClearKey EME v1 decryption support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 00:21:49 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=154235

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #13)
> Comment on attachment 271332 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271332&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/WebKitCommonEncryptionDecryptorGStreamer.cpp:210
> >> +    protectionMeta = reinterpret_cast<GstProtectionMeta*>(gst_buffer_get_protection_meta(buffer));
> > 
> > Why reinterpret cast? What does gst_buffer_get_protection_meta returns? a GstMeta*? I would make protectionMeta a GstMeta* instead and we don't need all the casts
> 
> We need a GstProtectionMeta because we use its info GstStructure below,
> which the base GstMeta struct doesn't have.

I know, my point is that you can get the GstMeta and cast to GstProtectionMeta only once, instead of casting the result to GstProtectionMeta and then casting again to GstMeta everywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/f28554d2/attachment.html>


More information about the webkit-unassigned mailing list