<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235">bug 154235</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154235#c13">comment #13</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271332&action=diff" name="attach_271332" title="patch">attachment 271332</a> <a href="attachment.cgi?id=271332&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271332&action=review">https://bugs.webkit.org/attachment.cgi?id=271332&action=review</a>
>
> >> Source/WebCore/platform/graphics/gstreamer/WebKitCommonEncryptionDecryptorGStreamer.cpp:210
> >> + protectionMeta = reinterpret_cast<GstProtectionMeta*>(gst_buffer_get_protection_meta(buffer));
> >
> > Why reinterpret cast? What does gst_buffer_get_protection_meta returns? a GstMeta*? I would make protectionMeta a GstMeta* instead and we don't need all the casts
>
> We need a GstProtectionMeta because we use its info GstStructure below,
> which the base GstMeta struct doesn't have.</span >
I know, my point is that you can get the GstMeta and cast to GstProtectionMeta only once, instead of casting the result to GstProtectionMeta and then casting again to GstMeta everywhere.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>