[Webkit-unassigned] [Bug 153813] Accepted candidates should not be autocorrected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153813

--- Comment #3 from Tim Horton <thorton at apple.com> ---
(In reply to comment #2)
> Comment on attachment 270540 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270540&action=review
> 
> Can we make a regression test for this?
> 
> > Source/WebCore/editing/Editor.cpp:3575
> > +    RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength);
> 
> If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a
> Ref. If not, then the next line could result in a crash, and so we should
> add a null check.

Pretty sure it's the latter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/52b25001/attachment.html>