<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Accepted candidates should not be autocorrected"
href="https://bugs.webkit.org/show_bug.cgi?id=153813#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Accepted candidates should not be autocorrected"
href="https://bugs.webkit.org/show_bug.cgi?id=153813">bug 153813</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153813#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=270540&action=diff" name="attach_270540" title="Patch">attachment 270540</a> <a href="attachment.cgi?id=270540&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=270540&action=review">https://bugs.webkit.org/attachment.cgi?id=270540&action=review</a>
>
> Can we make a regression test for this?
>
> > Source/WebCore/editing/Editor.cpp:3575
> > + RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength);
>
> If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a
> Ref. If not, then the next line could result in a crash, and so we should
> add a null check.</span >
Pretty sure it's the latter.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>