[Webkit-unassigned] [Bug 153813] Accepted candidates should not be autocorrected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153813

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270540|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 270540
  --> https://bugs.webkit.org/attachment.cgi?id=270540
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270540&action=review

Can we make a regression test for this?

> Source/WebCore/editing/Editor.cpp:3575
> +    RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength);

If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a Ref. If not, then the next line could result in a crash, and so we should add a null check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/48ff484c/attachment.html>