[Webkit-unassigned] [Bug 157133] Move ResourceTiming behind a runtime flag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 12:25:14 PDT 2016


--- Comment #7 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to comment #5)
> Comment on attachment 277621 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277621&action=review
> Probably r=me.  I have two questions:
> A resourceTimingBufferSize is set.  Is a buffer allocated if the feature is
> disabled at run time?
> How is the timing data collected?  It shouldn't be collected if the feature
> is disabled at run time.

When the feature is disabled at runtime, A vector of RefPtr<PerformanceEntry> is created, but nothing is ever appended to it, nor does it get allocated to resourceTimingBufferSize.

The timing data is not collected when the feature is disabled, as addResourceTiming() in CachedResourceLoader::loadDone() is never called unless RuntimeEnabledFeatures()::sharedFeatures().resourceTimingEnabled().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160428/25673bf9/attachment.html>

More information about the webkit-unassigned mailing list