<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133">bug 157133</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157133#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=277621&action=diff" name="attach_277621" title="Patch">attachment 277621</a> <a href="attachment.cgi?id=277621&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=277621&action=review">https://bugs.webkit.org/attachment.cgi?id=277621&action=review</a>
>
> Probably r=me. I have two questions:
> A resourceTimingBufferSize is set. Is a buffer allocated if the feature is
> disabled at run time?
> How is the timing data collected? It shouldn't be collected if the feature
> is disabled at run time.
> </span >
When the feature is disabled at runtime, A vector of RefPtr<PerformanceEntry> is created, but nothing is ever appended to it, nor does it get allocated to resourceTimingBufferSize.
The timing data is not collected when the feature is disabled, as addResourceTiming() in CachedResourceLoader::loadDone() is never called unless RuntimeEnabledFeatures()::sharedFeatures().resourceTimingEnabled().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>