[Webkit-unassigned] [Bug 157133] Move ResourceTiming behind a runtime flag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 12:18:56 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157133

--- Comment #6 from Yoav Weiss <yoav at yoav.ws> ---
Comment on attachment 277621
  --> https://bugs.webkit.org/attachment.cgi?id=277621
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277621&action=review

>> Source/WebCore/ChangeLog:5248
>> +2016-04-28  2016-04-18  Brady Eidson  <beidson at apple.com>
> 
> This change must have been an accident.

Indeed

>> Source/WebCore/page/Performance.idl:39
>> +    [EnabledAtRuntime=ResourceTiming] PerformanceEntryList webkitGetEntries();
> 
> Since we've never shipped this before, now would be a good time to unprefix everything in this file.

With pleasure! :)

>> LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html:36
>> +    if (typeof value == "object" && value == null) //;
> 
> What's with the //;?

I copied this test from another one, and just enabled resource timing . I'll get rid of the "//;" (in both tests).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160428/e1e35860/attachment.html>


More information about the webkit-unassigned mailing list