<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133">bug 157133</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277621&action=diff" name="attach_277621" title="Patch">attachment 277621</a> <a href="attachment.cgi?id=277621&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277621&action=review">https://bugs.webkit.org/attachment.cgi?id=277621&action=review</a>
<span class="quote">>> Source/WebCore/ChangeLog:5248
>> +2016-04-28 2016-04-18 Brady Eidson <<a href="mailto:beidson@apple.com">beidson@apple.com</a>>
>
> This change must have been an accident.</span >
Indeed
<span class="quote">>> Source/WebCore/page/Performance.idl:39
>> + [EnabledAtRuntime=ResourceTiming] PerformanceEntryList webkitGetEntries();
>
> Since we've never shipped this before, now would be a good time to unprefix everything in this file.</span >
With pleasure! :)
<span class="quote">>> LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html:36
>> + if (typeof value == "object" && value == null) //;
>
> What's with the //;?</span >
I copied this test from another one, and just enabled resource timing . I'll get rid of the "//;" (in both tests).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>