[Webkit-unassigned] [Bug 149595] [WTR] Pixel tests generate the snapshots twice in Web and UI processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149595

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 262008 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262008&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> > +        // Only IOS needs to generate the snapshot in the web process, all other ports generate
> 
> iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS
> yet.

Ok, I'll reword it to clarify that.

> > Tools/WebKitTestRunner/TestInvocation.cpp:293
> > +            dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);
> 
> no curly braces

Ok.

> > Tools/WebKitTestRunner/TestInvocation.cpp:377
> > +        if (!m_needsPixelResult) {
> 
> This reads pretty weird. "If I don't need a pixel result, extract the pixel
> result image". Maybe "needs" should be "pending" or some variation of that,
> since that's what it seems to be (we set it to false when we get a snapshot).

Agree, pending sounds better. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150929/4f4ec132/attachment.html>