[Webkit-unassigned] [Bug 149595] [WTR] Pixel tests generate the snapshots twice in Web and UI processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149595

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262008|review?                     |review+
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 262008
  --> https://bugs.webkit.org/attachment.cgi?id=262008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262008&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> +        // Only IOS needs to generate the snapshot in the web process, all other ports generate

iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS yet.

> Tools/WebKitTestRunner/TestInvocation.cpp:293
> +            dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);

no curly braces

> Tools/WebKitTestRunner/TestInvocation.cpp:377
> +        if (!m_needsPixelResult) {

This reads pretty weird. "If I don't need a pixel result, extract the pixel result image". Maybe "needs" should be "pending" or some variation of that, since that's what it seems to be (we set it to false when we get a snapshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150928/a6a48f49/attachment-0001.html>