<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WTR] Pixel tests generate the snapshots twice in Web and UI processes"
href="https://bugs.webkit.org/show_bug.cgi?id=149595#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WTR] Pixel tests generate the snapshots twice in Web and UI processes"
href="https://bugs.webkit.org/show_bug.cgi?id=149595">bug 149595</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=149595#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=262008&action=diff" name="attach_262008" title="Patch">attachment 262008</a> <a href="attachment.cgi?id=262008&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=262008&action=review">https://bugs.webkit.org/attachment.cgi?id=262008&action=review</a>
>
> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> > + // Only IOS needs to generate the snapshot in the web process, all other ports generate
>
> iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS
> yet.</span >
Ok, I'll reword it to clarify that.
<span class="quote">> > Tools/WebKitTestRunner/TestInvocation.cpp:293
> > + dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);
>
> no curly braces</span >
Ok.
<span class="quote">> > Tools/WebKitTestRunner/TestInvocation.cpp:377
> > + if (!m_needsPixelResult) {
>
> This reads pretty weird. "If I don't need a pixel result, extract the pixel
> result image". Maybe "needs" should be "pending" or some variation of that,
> since that's what it seems to be (we set it to false when we get a snapshot).</span >
Agree, pending sounds better. Thanks</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>