<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WTR] Pixel tests generate the snapshots twice in Web and UI processes"
href="https://bugs.webkit.org/show_bug.cgi?id=149595">bug 149595</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262008 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WTR] Pixel tests generate the snapshots twice in Web and UI processes"
href="https://bugs.webkit.org/show_bug.cgi?id=149595#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WTR] Pixel tests generate the snapshots twice in Web and UI processes"
href="https://bugs.webkit.org/show_bug.cgi?id=149595">bug 149595</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262008&action=diff" name="attach_262008" title="Patch">attachment 262008</a> <a href="attachment.cgi?id=262008&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262008&action=review">https://bugs.webkit.org/attachment.cgi?id=262008&action=review</a>
<span class="quote">> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> + // Only IOS needs to generate the snapshot in the web process, all other ports generate</span >
iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS yet.
<span class="quote">> Tools/WebKitTestRunner/TestInvocation.cpp:293
> + dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);</span >
no curly braces
<span class="quote">> Tools/WebKitTestRunner/TestInvocation.cpp:377
> + if (!m_needsPixelResult) {</span >
This reads pretty weird. "If I don't need a pixel result, extract the pixel result image". Maybe "needs" should be "pending" or some variation of that, since that's what it seems to be (we set it to false when we get a snapshot).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>