[Webkit-unassigned] [Bug 149567] Expose a WKWebView API for allowing programmatic focus to trigger node assistance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 26 21:01:33 PDT 2015


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 261960
  --> https://bugs.webkit.org/attachment.cgi?id=261960

View in context: https://bugs.webkit.org/attachment.cgi?id=261960&action=review

Thanks for taking a look! I'll switch to using an aggregate initializer before landing.

>> Source/WebKit2/UIProcess/WebPageProxy.h:258
>> +    }
> A struct does not need a constructor like this in modern C++. We can use aggregate initializer syntax instead.

Got it. I'll take out the constructor.

>> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:816
>> +        m_deferredNodeAssistanceArguments = std::make_unique<NodeAssistanceArguments>(information, userIsInteracting, blurPreviousNode, userDataObject);
> I believe the only change needed when we remove the constructor is to add braces here:
>     std::make_unique<NodeAssistanceArguments>({ information, userIsInteracting, blurPreviousNode, userDataObject });

Got it. I'll keep this in mind.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150927/ebd916e2/attachment.html>

More information about the webkit-unassigned mailing list