<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Expose a WKWebView API for allowing programmatic focus to trigger node assistance"
href="https://bugs.webkit.org/show_bug.cgi?id=149567#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Expose a WKWebView API for allowing programmatic focus to trigger node assistance"
href="https://bugs.webkit.org/show_bug.cgi?id=149567">bug 149567</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261960&action=diff" name="attach_261960" title="Patch">attachment 261960</a> <a href="attachment.cgi?id=261960&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261960&action=review">https://bugs.webkit.org/attachment.cgi?id=261960&action=review</a>
Thanks for taking a look! I'll switch to using an aggregate initializer before landing.
<span class="quote">>> Source/WebKit2/UIProcess/WebPageProxy.h:258
>> + }
>
> A struct does not need a constructor like this in modern C++. We can use aggregate initializer syntax instead.</span >
Got it. I'll take out the constructor.
<span class="quote">>> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:816
>> + m_deferredNodeAssistanceArguments = std::make_unique<NodeAssistanceArguments>(information, userIsInteracting, blurPreviousNode, userDataObject);
>
> I believe the only change needed when we remove the constructor is to add braces here:
>
> std::make_unique<NodeAssistanceArguments>({ information, userIsInteracting, blurPreviousNode, userDataObject });</span >
Got it. I'll keep this in mind.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>