[Webkit-unassigned] [Bug 149567] Expose a WKWebView API for allowing programmatic focus to trigger node assistance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149567

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261960|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 261960
  --> https://bugs.webkit.org/attachment.cgi?id=261960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261960&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:258
> +    NodeAssistanceArguments(const AssistedNodeInformation& nodeInformation, bool userIsInteracting, bool blurPreviousNode, API::Object* userData)
> +        : m_nodeInformation(nodeInformation)
> +        , m_userIsInteracting(userIsInteracting)
> +        , m_blurPreviousNode(blurPreviousNode)
> +        , m_userData(userData)
> +    {
> +    }

A struct does not need a constructor like this in modern C++. We can use aggregate initializer syntax instead.

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:816
> +        m_deferredNodeAssistanceArguments = std::make_unique<NodeAssistanceArguments>(information, userIsInteracting, blurPreviousNode, userDataObject);

I believe the only change needed when we remove the constructor is to add braces here:

    std::make_unique<NodeAssistanceArguments>({ information, userIsInteracting, blurPreviousNode, userDataObject });

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150927/4c44a480/attachment.html>