<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Expose a WKWebView API for allowing programmatic focus to trigger node assistance"
href="https://bugs.webkit.org/show_bug.cgi?id=149567">bug 149567</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261960 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Expose a WKWebView API for allowing programmatic focus to trigger node assistance"
href="https://bugs.webkit.org/show_bug.cgi?id=149567#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Expose a WKWebView API for allowing programmatic focus to trigger node assistance"
href="https://bugs.webkit.org/show_bug.cgi?id=149567">bug 149567</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261960&action=diff" name="attach_261960" title="Patch">attachment 261960</a> <a href="attachment.cgi?id=261960&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261960&action=review">https://bugs.webkit.org/attachment.cgi?id=261960&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.h:258
> + NodeAssistanceArguments(const AssistedNodeInformation& nodeInformation, bool userIsInteracting, bool blurPreviousNode, API::Object* userData)
> + : m_nodeInformation(nodeInformation)
> + , m_userIsInteracting(userIsInteracting)
> + , m_blurPreviousNode(blurPreviousNode)
> + , m_userData(userData)
> + {
> + }</span >
A struct does not need a constructor like this in modern C++. We can use aggregate initializer syntax instead.
<span class="quote">> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:816
> + m_deferredNodeAssistanceArguments = std::make_unique<NodeAssistanceArguments>(information, userIsInteracting, blurPreviousNode, userDataObject);</span >
I believe the only change needed when we remove the constructor is to add braces here:
std::make_unique<NodeAssistanceArguments>({ information, userIsInteracting, blurPreviousNode, userDataObject });</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>