[Webkit-unassigned] [Bug 149304] Heavy taps on links are sometimes interpreted as the preview gesture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 16:06:12 PDT 2015


--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 261439
  --> https://bugs.webkit.org/attachment.cgi?id=261439

View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162
> +    double _lastPreviewStartTime;

Is there a way to use std::chrono types for this instead of a mix of doubles and floats?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386
> +static const double gMaximumAccidentalPreviewTime = 250;

Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150917/9f881e46/attachment.html>

More information about the webkit-unassigned mailing list