<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Heavy taps on links are sometimes interpreted as the preview gesture"
href="https://bugs.webkit.org/show_bug.cgi?id=149304#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Heavy taps on links are sometimes interpreted as the preview gesture"
href="https://bugs.webkit.org/show_bug.cgi?id=149304">bug 149304</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261439&action=diff" name="attach_261439" title="Patch">attachment 261439</a> <a href="attachment.cgi?id=261439&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261439&action=review">https://bugs.webkit.org/attachment.cgi?id=261439&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162
> + double _lastPreviewStartTime;</span >
Is there a way to use std::chrono types for this instead of a mix of doubles and floats?
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386
> +static const double gMaximumAccidentalPreviewTime = 250;</span >
Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>