[Webkit-unassigned] [Bug 149304] Heavy taps on links are sometimes interpreted as the preview gesture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 16:21:40 PDT 2015


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #261439|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 261439
  --> https://bugs.webkit.org/attachment.cgi?id=261439

View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162
>> +    double _lastPreviewStartTime;
> Is there a way to use std::chrono types for this instead of a mix of doubles and floats?

Chrono would be good (at the very least, using double everywhere). You can store the time from std::chrono::steady_clock::now() and do something like "std::chrono::duration_cast<std::chrono::milliseconds>(
            std::chrono::steady_clock::now() - _lastPreviewStartTime)" and compare to the literal 250_ms

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386
>> +static const double gMaximumAccidentalPreviewTime = 250;
> Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix.

Agreed about the g. Don't care if you keep the named constant, but it should at least be inside the function, I guess?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150917/728db8ed/attachment.html>

More information about the webkit-unassigned mailing list